Fwd: [PATCH net] net: ethernet: marvell: octeontx2: nic: Add error pointer check in otx2_common.c

[Dipendra Khadka]

---------- Forwarded message ---------
From: Dipendra Khadka <kdipendra88@xxxxxxxxx>
Date: Mon, 23 Sept 2024 at 16:51
Subject: [PATCH net] net: ethernet: marvell: octeontx2: nic: Add error
pointer check in otx2_common.c
To: <sgoutham@xxxxxxxxxxx>, <gakula@xxxxxxxxxxx>,
<sbhatta@xxxxxxxxxxx>, <hkelam@xxxxxxxxxxx>, <davem@xxxxxxxxxxxxx>,
<edumazet@xxxxxxxxxx>, <kuba@xxxxxxxxxx>, <pabeni@xxxxxxxxxx>
Cc: Dipendra Khadka <kdipendra88@xxxxxxxxx>, <netdev@xxxxxxxxxxxxxxx>,
<cc=linux-kernel@xxxxxxxxxxxxxxx>


Add error pointer check after calling otx2_mbox_get_rsp().

Signed-off-by: Dipendra Khadka <kdipendra88@xxxxxxxxx>
---
 drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
index 87d5776e3b88..6e5f1b2e8c52 100644
--- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
+++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
@@ -1838,6 +1838,11 @@ u16 otx2_get_max_mtu(struct otx2_nic *pfvf)
                rsp = (struct nix_hw_info *)
                       otx2_mbox_get_rsp(&pfvf->mbox.mbox, 0, &req->hdr);

+               if (IS_ERR(rsp)) {
+                       mutex_unlock(&pfvf->mbox.lock);
+                       return PTR_ERR(rsp);
+               }
+
                /* HW counts VLAN insertion bytes (8 for double tag)
                 * irrespective of whether SQE is requesting to insert VLAN
                 * in the packet or not. Hence these 8 bytes have to be
--
2.43.0