Re: [PATCH v7 02/24] x86/resctrl: Add ABMC feature in the command line options

[Moger, Babu]

Hi Reinette,

On 9/19/24 11:00, Reinette Chatre wrote:
> Hi Babu,
> 
> On 9/4/24 3:21 PM, Babu Moger wrote:
>> Add the command line option to enable or disable the new resctrl feature
>> ABMC (Assignable Bandwidth Monitoring Counters).
> 
> This does not reflect the fs and arch separation that this version highlights
> since ABMC is not a resctrl feature.
> 
> This can get confusing and I think this interface is indeed for the
> architecture where hardware features are enabled/disabled (highlighted
> by how the parameter is connected to the X86_FEATURE_ flag) ... so
> perhaps something like:
> 
> 	Add the command line option to enable or disable exposing
> 	the ABMC (Assignable Bandwidth Monitoring Counters) hardware
> 	feature to resctrl.

Sure.

> 
> Patch looks good to me.

-- 
Thanks
Babu Moger