Re: [PATCH v7 04/24] x86/resctrl: Detect Assignable Bandwidth Monitoring feature details

[Moger, Babu]

Hi Reinette,

On 9/19/24 11:16, Reinette Chatre wrote:
> Hi Babu,
> 
> On 9/4/24 3:21 PM, Babu Moger wrote:
>> diff --git a/arch/x86/kernel/cpu/resctrl/monitor.c b/arch/x86/kernel/cpu/resctrl/monitor.c
>> index 795fe91a8feb..6a792f06f5ce 100644
>> --- a/arch/x86/kernel/cpu/resctrl/monitor.c
>> +++ b/arch/x86/kernel/cpu/resctrl/monitor.c
>> @@ -1229,6 +1229,12 @@ int __init rdt_get_mon_l3_config(struct rdt_resource *r)
>>  			mbm_local_event.configurable = true;
>>  			mbm_config_rftype_init("mbm_local_bytes_config");
>>  		}
>> +
>> +		if (rdt_cpu_has(X86_FEATURE_ABMC)) {
>> +			r->mon.mbm_cntr_assignable = true;
>> +			cpuid_count(0x80000020, 5, &eax, &ebx, &ecx, &edx);
>> +			r->mon.num_mbm_cntrs = (ebx & 0xFFFF) + 1;
> 
> This should use GENMASK()

Sure.
-- 
Thanks
Babu Moger