RE: [PATCH] hexagon: vdso: Fix build failure

From: Brian Cain
Date: Mon Sep 23 2024 - 11:15:53 EST


> -----Original Message-----
> From: Guenter Roeck <groeck7@xxxxxxxxx> On Behalf Of Guenter Roeck
> Sent: Monday, September 23, 2024 8:53 AM
> To: Brian Cain <bcain@xxxxxxxxxxx>
> Cc: linux-hexagon@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Guenter
> Roeck <linux@xxxxxxxxxxxx>; Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> Subject: [PATCH] hexagon: vdso: Fix build failure
>
> WARNING: This email originated from outside of Qualcomm. Please be wary of
> any links or attachments, and do not enable macros.
>
> Hexagon images fail to build with the following error.
>
> arch/hexagon/kernel/vdso.c:57:3: error: use of undeclared identifier 'name'
> name = "[vdso]",
> ^
>
> Add the missing '.' to fix the problem.
>
> Fixes: 497258dfafcc ("mm: remove legacy install_special_mapping() code")
> Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> ---

Reviewed-by: Brian Cain <bcain@xxxxxxxxxxx>

> arch/hexagon/kernel/vdso.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/hexagon/kernel/vdso.c b/arch/hexagon/kernel/vdso.c
> index 6fd27ff1df73..8119084dc519 100644
> --- a/arch/hexagon/kernel/vdso.c
> +++ b/arch/hexagon/kernel/vdso.c
> @@ -54,7 +54,7 @@ int arch_setup_additional_pages(struct linux_binprm
> *bprm, int uses_interp)
> struct vm_area_struct *vma;
> struct mm_struct *mm = current->mm;
> static struct vm_special_mapping vdso_mapping = {
> - name = "[vdso]",
> + .name = "[vdso]",
> };
>
> if (mmap_write_lock_killable(mm))
> --
> 2.45.2
>