Re: [PATCH v3 2/4] pm:cpupower: Add SWIG bindings files for libcpupower

From: Shuah Khan
Date: Mon Sep 23 2024 - 12:09:57 EST


On 9/23/24 07:29, John B. Wyatt IV wrote:
On Sun, Sep 22, 2024 at 08:39:28AM -0700, Linus Torvalds wrote:
On Sat, 21 Sept 2024 at 14:23, Guenter Roeck <linux@xxxxxxxxxxxx> wrote:

On Wed, Sep 04, 2024 at 10:19:09PM -0400, John B. Wyatt IV wrote:

.../bindings/python/raw_pylibcpupower.i | 247 ++++++++++++++++++

This file is deleted when running "make mrproper".

Yes, please don't create files called '*.i", "*.s" or "*.o". We
assume they are generated files (the result of the preprocessor, the
compiler, and the assembler respectively).

And yeah, obviously "*.i" and "*.s" and not _usually_ seen, because
they are only steps on the way to "*.o", so maybe they aren't _quite_
as obvious as some "*.o" file would be, but they are very much
standard naming, and we have build rules for them (ie "make
kernel/exit.i" will create the pre-processed result of exit.c).


My apologies. This was reported and fixed with this patch by renaming
the file to '.swg'. '.swg' is the second filename extension used by
SWIG.

https://lore.kernel.org/linux-pm/20240913201705.7764-1-minhuadotchen@xxxxxxxxx/


It was quickly found and fixed. I will send this to Rafael to get this into rc1.

thanks,
-- Shuah