Re: [PATCH] regulator: do not ignore provided init_data
From: Jerome Brunet
Date: Mon Sep 23 2024 - 12:50:45 EST
On Mon 23 Sep 2024 at 16:19, Mark Brown <broonie@xxxxxxxxxx> wrote:
> On Fri, Sep 20, 2024 at 07:21:12PM +0200, Jerome Brunet wrote:
>
>> Note that it is probably not problem at the moment since no one complained
>> about ignored data.
>
> I'm fine with tweaking the functionality here but since I don't think
> we're using this at all we should probably warn about systems with both
> forms of constraints specified since they probably need some
> consideration needed and people might not be doing this intentionally.
>
> That probably means checking if regulator_of_get_init_node() can find
> something and warning if that's the case.
We could warn if both init_data and desc->of_match are set ?
Setting desc->of_match is an indication regulator is expected to search
DT, is'nt it ? Having both set be the indicaction of the conflict.
Maybe the warn is enough then. Do you prefer if I keep the change of v1
or drop it ?
--
Jerome