Re: [PATCH 3/3] ath6kl: Reduce scopes for two variables in ath6kl_sdio_power_on()

From: Markus Elfring
Date: Mon Sep 23 2024 - 13:01:13 EST


>> Adjust the definitions for the local variables "func" and "ret"
>> so that the corresponding setting will be performed a bit later.

>> +++ b/drivers/net/wireless/ath/ath6kl/sdio.c
>> @@ -503,17 +503,15 @@ static void ath6kl_sdio_irq_handler(struct sdio_func *func)
>> static int ath6kl_sdio_power_on(struct ath6kl *ar)
>> {
>> struct ath6kl_sdio *ar_sdio = ath6kl_sdio_priv(ar);
>> - struct sdio_func *func = ar_sdio->func;
>> - int ret = 0;
>>
>> if (!ar_sdio->is_disabled)
>> return 0;
>>
>> ath6kl_dbg(ATH6KL_DBG_BOOT, "sdio power on\n");
>> -
>> + struct sdio_func *func = ar_sdio->func;
>> sdio_claim_host(func);
>>
>> - ret = sdio_enable_func(func);
>> + int ret = sdio_enable_func(func);
>> sdio_release_host(func);
>> if (ret) {
>> ath6kl_err("Unable to enable sdio func: %d)\n", ret);
>> --
>> 2.46.0
>
> NAK
>
> no maintainer wants to spend time on patches like this which bring no real
> value to code that is not actively being maintained, and which violates the
> established understanding that, except under certain recently established
> criteria, declarations and code should not be interleaved.


Would you find other software design options more acceptable for further
collateral evolution?

1. Additional compound statements (by using extra curly brackets)

2. Moving a bit of source code into an additional function implementation


Regards,
Markus