Re: [PATCH] ipe: Add missing terminator to list of unit tests

[Fan Wu]

On 9/22/2024 5:27 PM, Paul Moore wrote:
> On Sun, Sep 22, 2024 at 10:52 AM Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
> > Add missing terminator to list of unit tests to avoid random crashes seen
> > when running the test.
> >
> > Fixes: 10ca05a76065 ("ipe: kunit test for parser")
> > Cc: Deven Bowers <deven.desai@xxxxxxxxxxxxxxxxxxx>
> > Cc: Paul Moore <paul@xxxxxxxxxxxxxx>
> > Cc: Fan Wu <wufan@xxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> > ---
> >   security/ipe/policy_tests.c | 1 +
> >   1 file changed, 1 insertion(+)
>
> I'm guessing Fan doesn't have his tree setup yet, but if I can get an
> ACK from Fan I can send this up via the LSM tree for the next
> v6.12-rcX release.
>
> > diff --git a/security/ipe/policy_tests.c b/security/ipe/policy_tests.c
> > index 89521f6b9994..5f1654deeb04 100644
> > --- a/security/ipe/policy_tests.c
> > +++ b/security/ipe/policy_tests.c
> > @@ -286,6 +286,7 @@ static void ipe_parser_widestring_test(struct kunit *test)
> >   static struct kunit_case ipe_parser_test_cases[] = {
> >          KUNIT_CASE_PARAM(ipe_parser_unsigned_test, ipe_policies_gen_params),
> >          KUNIT_CASE(ipe_parser_widestring_test),
> > +       { }
> >   };
> >
> >   static struct kunit_suite ipe_parser_test_suite = {

Yes this looks good to me.

Acked-by: Fan Wu <wufan@xxxxxxxxxxxxxxxxxxx>