Re: ice: Use common error handling code in two functions

From: Tony Nguyen
Date: Mon Sep 23 2024 - 14:27:11 EST




On 9/20/2024 12:05 AM, Markus Elfring wrote:
Add jump targets so that a bit of exception handling can be better reused
at the end of two function implementations.

Thank you for contribution, the change is fine,

Thanks for this positive feedback.


but not as a bugfix.

Would you like to qualify my update suggestion as a correction for
a coding style issue?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.11#n526

It can go to -next to correct the coding style, however, for -net it should be user visible bugs.

Please send as a [iwl-next], when the submission window opens.

Will a patch resend really be needed for the proposed adjustment?

I'll go ahead and apply this to iwl-next without a re-send, but please keep Przemek's comments in mind for future submissions.

Thanks,
Tony