Re: [Intel-wired-lan] [PATCH 2/2] igbvf: remove unused spinlock

From: Tony Nguyen
Date: Mon Sep 23 2024 - 14:44:49 EST




On 9/23/2024 9:46 AM, Wander Lairson Costa wrote:
On Mon, Sep 23, 2024 at 6:04 AM Przemek Kitszel
<przemyslaw.kitszel@xxxxxxxxx> wrote:

On 9/21/24 14:52, Paul Menzel wrote:
Dear Wander,


Thank you for your patch.

Am 20.09.24 um 20:59 schrieb Wander Lairson Costa:
tx_queue_lock and stats_lock are declared and initialized, but never
used. Remove them.

Signed-off-by: Wander Lairson Costa <wander@xxxxxxxxxx>

It’d be great if you added a Fixes: tag.

Alternatively you could split this series into two, and send this patch
to iwl-next tree, without the fixes tag. For me this patch is just
a cleanup, not a fix.




Should I send a new version of the patches separately?

The patches apply to the respective trees when split out so I can take these without a re-send. Patch 1 will need a Fixes: for it though...

I'm seeing it as: 9d5c824399de ("igb: PCI-Express 82575 Gigabit Ethernet driver")?

Thanks,
Tony

[...]


With that addressed:

Reviewed-by: Paul Menzel <pmenzel@xxxxxxxxxxxxx>


Kind regards,

Paul