Re: [RFC PATCH 3/4] block: add support for partition table defined in OF

[Christoph Hellwig]

On Mon, Sep 23, 2024 at 12:59:32PM +0200, Christian Marangi wrote:
> +#define BOOT0_STR	"boot0"
> +#define BOOT1_STR	"boot1"
> +

This boot0/1 stuff looks like black magic, so it should probably be
documented at very least.

> +	partitions_np = get_partitions_node(disk_np,
> +					    state->disk->disk_name);

disk->disk_name is not a stable identifier and can change from boot to
boot due to async probing.  You'll need to check a uuid or label instead.