Re: [PATCH v3 09/29] media: iris: introduce Host firmware interface with necessary hooks

[Dikshita Agarwal]

On 9/5/2024 6:06 PM, Bryan O'Donoghue wrote:
> On 27/08/2024 11:05, Dikshita Agarwal via B4 Relay wrote:
>> +enum hfi_packet_port_type {
>> +    HFI_PORT_NONE        = 0x00000000,
>> +    HFI_PORT_BITSTREAM    = 0x00000001,
>> +    HFI_PORT_RAW        = 0x00000002,
>> +};
>> +
>> +enum hfi_packet_payload_info {
>> +    HFI_PAYLOAD_NONE    = 0x00000000,
>> +    HFI_PAYLOAD_U32        = 0x00000001,
>> +    HFI_PAYLOAD_S32        = 0x00000002,
>> +    HFI_PAYLOAD_U64        = 0x00000003,
>> +    HFI_PAYLOAD_S64        = 0x00000004,
>> +    HFI_PAYLOAD_STRUCTURE    = 0x00000005,
>> +    HFI_PAYLOAD_BLOB    = 0x00000006,
>> +    HFI_PAYLOAD_STRING    = 0x00000007,
>> +    HFI_PAYLOAD_Q16        = 0x00000008,
>> +    HFI_PAYLOAD_U32_ENUM    = 0x00000009,
>> +    HFI_PAYLOAD_32_PACKED    = 0x0000000a,
>> +    HFI_PAYLOAD_U32_ARRAY    = 0x0000000b,
>> +    HFI_PAYLOAD_S32_ARRAY    = 0x0000000c,
>> +    HFI_PAYLOAD_64_PACKED    = 0x0000000d,
>> +};
>> +
>> +enum hfi_packet_host_flags {
>> +    HFI_HOST_FLAGS_NONE            = 0x00000000,
> 
> Are these NONE flags used/necessary ?
> 
> If they are dead enum values, please drop in the next version.
Sure, will check and remove if not needed.
> 
> ---
> bod