RE: [PATCH v1] ARM: dts: aspeed: yosemite4: Revise quad mode to dual mode

[Delphine_CC_Chiu/WYHQ/Wiwynn]

> -----Original Message-----
> From: Andrew Jeffery <andrew@xxxxxxxxxxxxxxxxxxxx>
> Sent: Thursday, September 12, 2024 10:17 AM
> To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@xxxxxxxxxx>;
> patrick@xxxxxxxxx; Rob Herring <robh@xxxxxxxxxx>; Krzysztof Kozlowski
> <krzk+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>; Joel Stanley
> <joel@xxxxxxxxx>
> Cc: Ricky CX Wu <ricky.cx.wu.wiwynn@xxxxxxxxx>;
> devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> linux-aspeed@xxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v1] ARM: dts: aspeed: yosemite4: Revise quad mode to
> dual mode
> 
>  [External Sender]
> 
>  [External Sender]
> 
> On Tue, 2024-09-10 at 13:13 +0800, Delphine CC Chiu wrote:
> > From: Ricky CX Wu <ricky.cx.wu.wiwynn@xxxxxxxxx>
> >
> > Revise quad mode to dual mode to avoid WP pin influnece the SPI.
> >
> > Signed-off-by: Ricky CX Wu <ricky.cx.wu.wiwynn@xxxxxxxxx>
> > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@xxxxxxxxxx>
> > ---
> >  .../arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts | 8
> > +++++---
> >  1 file changed, 5 insertions(+), 3 deletions(-)
> >
> > diff --git
> > a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> > b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> > index 98477792aa00..3073ade6d77c 100644
> > --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> > @@ -105,15 +105,17 @@ flash@0 {
> >               status = "okay";
> >               m25p,fast-read;
> >               label = "bmc";
> > -             spi-rx-bus-width = <4>;
> > +             spi-tx-bus-width = <2>;
> > +             spi-rx-bus-width = <2>;
> >               spi-max-frequency = <50000000>; -#include
> > "openbmc-flash-layout-64.dtsi"
> > +#include "openbmc-flash-layout-128.dtsi"
> 
> This is a bit more drastic than changing the bus mode.
> 
> Can you please split that out to a separate change with some justification in
> the commit message? For instance, was the chip changed too? Or were you
> using the 64M layout or a 128M chip the whole time?
> 
> Andrew
I'll split the patch in v2. Thanks!