Re: [PATCH v3 1/8] x86/virt/tdx: Rename 'struct tdx_tdmr_sysinfo' to reflect the spec better
From: Huang, Kai
Date: Tue Sep 24 2024 - 07:40:27 EST
On Wed, 2024-08-28 at 10:20 +1200, Huang, Kai wrote:
>
> On 28/08/2024 1:10 am, Adrian Hunter wrote:
> > On 27/08/24 10:14, Kai Huang wrote:
> >
> > "to reflect the spec better" is a bit vague. How about:
> >
> > x86/virt/tdx: Rename 'struct tdx_tdmr_sysinfo' to 'struct tdx_sys_info_tdmr'
> >
> > Rename 'struct tdx_tdmr_sysinfo' to 'struct tdx_sys_info_tdmr' to
> > prepare for adding similar structures that will all be prefixed by
> > 'tdx_sys_info_'.
I decided not to do the patch title change and the above paragraph in v4, since
I believe they are nit and Dan already reviewed. Yeah I agree 'reflect spec
better' is a bit vague, but it kinda reflect the purpose. However IMHO albeit
"rename A to B" reflects the final code, it doesn't convey the purpose. So I
think the old title should also be fine.
Also the suggested paragraph is kinda duplicated with the last paragraph in the
current changelog so I didn't add it either.