Re: [PATCH] perf/x86/intel/uncore: Enable uncore on vCPUs when using uncore discovery

[Liang, Kan]

On 2024-09-23 10:47 p.m., 陈培鸿(乘鸿) wrote:
> With uncore discovery, kvm can choose to expose a subset of
> uncore related MSRs it wants to guest by emulate the uncore
> discovery device. 

I don't hear that the KVM has started to support uncore vPMU.
Can you please point me to patches?

The default of uncore_no_discover is 0. So it bypasses the HYPERVISOR
check unless the user specially sets the value. It could be a problem
for the earlier platforms which don't support discovery
table. How do you plan to emulate the devices on earlier platforms?

Thanks,
Kan
> So we can enable uncore on virtualized CPUs
> when uncore discovery is using.
> Signed-off-by: Cheng Hong <chenpeihong.cph@xxxxxxxxxxxxxxx>
> ---
>  arch/x86/events/intel/uncore.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/arch/x86/events/intel/uncore.c b/arch/x86/events/intel/uncore.c
> index d98fac567684..33776df95aa4 100644
> --- a/arch/x86/events/intel/uncore.c
> +++ b/arch/x86/events/intel/uncore.c
> @@ -1920,7 +1920,7 @@ static int __init intel_uncore_init(void)
>  struct intel_uncore_init_fun *uncore_init;
>  int pret = 0, cret = 0, mret = 0, ret;
> - if (boot_cpu_has(X86_FEATURE_HYPERVISOR))
> + if (uncore_no_discover && boot_cpu_has(X86_FEATURE_HYPERVISOR))
>  return -ENODEV;
>  __uncore_max_dies =