Re: [PATCH v7 09/24] x86/resctrl: Introduce bitmap mbm_cntr_free_map to track assignable counters
From: Moger, Babu
Date: Tue Sep 24 2024 - 13:01:33 EST
Hi Peter,
On 9/24/24 11:25, Peter Newman wrote:
> Hi Babu,
>
> On Wed, Sep 4, 2024 at 3:23 PM Babu Moger <babu.moger@xxxxxxx> wrote:
>
>> diff --git a/include/linux/resctrl.h b/include/linux/resctrl.h
>> index f11d6fdfd977..aab22ff8e0c1 100644
>> --- a/include/linux/resctrl.h
>> +++ b/include/linux/resctrl.h
>> @@ -187,12 +187,14 @@ enum resctrl_scope {
>> * @num_rmid: Number of RMIDs available
>> * @num_mbm_cntrs: Number of assignable monitoring counters
>> * @mbm_cntr_assignable:Is system capable of supporting monitor assignment?
>> + * @mbm_cntr_free_map: bitmap of number of assignable MBM counters
>> * @evt_list: List of monitoring events
>> */
>> struct resctrl_mon {
>> int num_rmid;
>> int num_mbm_cntrs;
>> bool mbm_cntr_assignable;
>> + unsigned long *mbm_cntr_free_map;
>> struct list_head evt_list;
>> };
>
> This looks global still. Will only all-domain (*=) operations be
> supported initially?
Yes. It is supported in this series.
We have one counter at global level and another at domain level.
https://lore.kernel.org/lkml/7a24bb182897acab3daaac1cadaabca3bcc73dc5.1725488488.git.babu.moger@xxxxxxx/
Domain level counter is used for tracking the counters status in each domain.
Global counter is released once the counter is freed in all the domains.
--
Thanks
Babu Moger