Re: [PATCH v2] m68k: Define NR_CPUS
From: Maciej W. Rozycki
Date: Tue Sep 24 2024 - 15:31:27 EST
On Tue, 24 Sep 2024, David Hildenbrand wrote:
> diff --git a/mm/Kconfig b/mm/Kconfig
> index 09aebca1cae3..4c9f5ea13271 100644
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -595,6 +595,7 @@ config ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE
> config SPLIT_PTE_PTLOCKS
> def_bool y
> depends on MMU
> + depends on SMP
> depends on NR_CPUS >= 4
I think it might be more intuitive if written as:
depends on SMP && NR_CPUS >= 4
(with a note in the change description to the effect that NR_CPUS will
have been unset and the condition won't work as expected unless SMP).
FWIW,
Maciej