Re: [PATCH v2 1/2] dt-bindings: phy: rockchip,inno-usb2phy: add rk3576

[Frank Wang]

Hi Heiko,

On 2024/9/24 18:01, Heiko Stuebner wrote:
> Hi Frank,
>
> Am Dienstag, 24. September 2024, 10:55:09 CEST schrieb Frank Wang:
> > From: Frank Wang <frank.wang@xxxxxxxxxxxxxx>
> >
> > Add compatible for the USB2 phy in the Rockchip RK3576 SoC.
> can you please add some details to the commit message, about those
> new clocks. I.e. what they do.

OK, I shall add in the next version.

BR.
Frank

> Thanks
> Heiko
>
> > Signed-off-by: Frank Wang <frank.wang@xxxxxxxxxxxxxx>
> > ---
> > Changelog:
> > v2:
> >   - Categorize clock names by oneOf keyword.
> >
> > v1:
> >   - https://patchwork.kernel.org/project/linux-phy/patch/20240923025326.10467-1-frank.wang@xxxxxxxxxxxxxx/
> >
> >   .../bindings/phy/rockchip,inno-usb2phy.yaml      | 16 ++++++++++++++--
> >   1 file changed, 14 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/phy/rockchip,inno-usb2phy.yaml b/Documentation/devicetree/bindings/phy/rockchip,inno-usb2phy.yaml
> > index 5254413137c64..8af4e0f8637fc 100644
> > --- a/Documentation/devicetree/bindings/phy/rockchip,inno-usb2phy.yaml
> > +++ b/Documentation/devicetree/bindings/phy/rockchip,inno-usb2phy.yaml
> > @@ -20,6 +20,7 @@ properties:
> >         - rockchip,rk3366-usb2phy
> >         - rockchip,rk3399-usb2phy
> >         - rockchip,rk3568-usb2phy
> > +      - rockchip,rk3576-usb2phy
> >         - rockchip,rk3588-usb2phy
> >         - rockchip,rv1108-usb2phy
> >   
> > @@ -34,10 +35,20 @@ properties:
> >       const: 0
> >   
> >     clocks:
> > -    maxItems: 1
> > +    minItems: 1
> > +    maxItems: 3
> >   
> >     clock-names:
> > -    const: phyclk
> > +    minItems: 1
> > +    maxItems: 3
> > +    items:
> > +      oneOf:
> > +        - description: aclk for USB MMU.
> > +          const: aclk
> > +        - description: aclk_slv for USB MMU.
> > +          const: aclk_slv
> > +        - description: PHY input reference clocks.
> > +          const: phyclk
> >   
> >     assigned-clocks:
> >       description:
> > @@ -143,6 +154,7 @@ allOf:
> >             contains:
> >               enum:
> >                 - rockchip,rk3568-usb2phy
> > +              - rockchip,rk3576-usb2phy
> >                 - rockchip,rk3588-usb2phy
> >   
> >       then: