Re: [RFC v3 2/2] usb: typec: tcpm: Add support for parsing time dt properties

[Amit Sunil Dhamne]

Hi Heikki,

On 9/24/24 5:55 AM, Heikki Krogerus wrote:
> Hi,
>
> > @@ -7611,10 +7650,13 @@ struct tcpm_port *tcpm_register_port(struct device *dev, struct tcpc_dev *tcpc)
> >   	err = tcpm_fw_get_caps(port, tcpc->fwnode);
> >   	if (err < 0)
> >   		goto out_destroy_wq;
> > +
>
> This extra newline is not relevant or necessary. Otherwise this LGTM:

Thanks for reviewing! Please let me know if I should upload a new set or 
this is alright at this time?

--

Amit

> Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
>
> >   	err = tcpm_fw_get_snk_vdos(port, tcpc->fwnode);
> >   	if (err < 0)
> >   		goto out_destroy_wq;
> >   
> > +	tcpm_fw_get_timings(port, tcpc->fwnode);
> > +
> >   	port->try_role = port->typec_caps.prefer_role;
> >   
> >   	port->typec_caps.revision = 0x0120;	/* Type-C spec release 1.2 */
> thanks,