Re: [PATCH 1/2] mm/slub: Add panic function when slub leaks
From: Greg KH
Date: Wed Sep 25 2024 - 04:11:16 EST
On Wed, Sep 25, 2024 at 11:22:55AM +0800, Fangzheng Zhang wrote:
> Perform real-time memory usage monitoring on the slub page
> allocation paths, ie, kmalloc_large_alloced and alloc_slab_page.
> When the usage exceeds the set threshole value, the panic function
> will be triggered.
>
> Signed-off-by: Fangzheng Zhang <fangzheng.zhang@xxxxxxxxxx>
> ---
> mm/Kconfig | 11 ++++++++
> mm/slub.c | 76 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 87 insertions(+)
>
> diff --git a/mm/Kconfig b/mm/Kconfig
> index 09aebca1cae3..60cf72d4f0da 100644
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -255,6 +255,17 @@ config SLUB_TINY
>
> If unsure, say N.
>
> +config SLUB_LEAK_PANIC
> + bool "Trigger panic when slub leaks"
> + default y
> + help
> + Detect slub leaks by monitoring its usage in real time on the page
> + allocation path of the slub. When the slub occupancy exceeds the
> + user-set value, it is considered that the slub is leaking at this
> + time, and a panic operation will be triggered immediately. Uers
> + can enable and set leak threshold by using the kernel command line
> + parameters "slub.leak_panic" and "slub.leak_panic_threshold".
> +
> config SLAB_MERGE_DEFAULT
> bool "Allow slab caches to be merged"
> default y
> diff --git a/mm/slub.c b/mm/slub.c
> index 21f71cb6cc06..91049f87ab98 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -42,6 +42,9 @@
> #include <kunit/test.h>
> #include <kunit/test-bug.h>
> #include <linux/sort.h>
> +#ifdef CONFIG_SLUB_LEAK_PANIC
> +#include <linux/vmstat.h>
> +#endif
Please redo this to not require #ifdef in .c files, otherwise it gets
very unmaintainable over time.
thanks,
greg k-h