Re: [PATCH v2] gpio: add support for FTDI's MPSSE as GPIO
From: Dan Carpenter
Date: Wed Sep 25 2024 - 04:18:37 EST
Hi Mary,
kernel test robot noticed the following build warnings:
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Mary-Strodl/gpio-add-support-for-FTDI-s-MPSSE-as-GPIO/20240919-221626
base: https://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git gpio/for-next
patch link: https://lore.kernel.org/r/20240919141014.4000958-1-mstrodl%40csh.rit.edu
patch subject: [PATCH v2] gpio: add support for FTDI's MPSSE as GPIO
config: x86_64-randconfig-161-20240922 (https://download.01.org/0day-ci/archive/20240923/202409230158.XhvhLOyY-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
| Closes: https://lore.kernel.org/r/202409230158.XhvhLOyY-lkp@xxxxxxxxx/
smatch warnings:
drivers/gpio/gpio-mpsse.c:211 gpio_mpsse_get_multiple() warn: inconsistent returns '&priv->io_mutex'.
vim +211 drivers/gpio/gpio-mpsse.c
be777399e9baea Mary Strodl 2024-09-19 190 static int gpio_mpsse_get_multiple(struct gpio_chip *chip, unsigned long *mask,
be777399e9baea Mary Strodl 2024-09-19 191 unsigned long *bits)
be777399e9baea Mary Strodl 2024-09-19 192 {
be777399e9baea Mary Strodl 2024-09-19 193 unsigned long i, bank, bank_mask;
be777399e9baea Mary Strodl 2024-09-19 194 int ret;
be777399e9baea Mary Strodl 2024-09-19 195 struct mpsse_priv *priv = gpiochip_get_data(chip);
be777399e9baea Mary Strodl 2024-09-19 196
be777399e9baea Mary Strodl 2024-09-19 197 mutex_lock(&priv->io_mutex);
be777399e9baea Mary Strodl 2024-09-19 198 for_each_set_clump8(i, bank_mask, mask, chip->ngpio) {
be777399e9baea Mary Strodl 2024-09-19 199 bank = i / 8;
be777399e9baea Mary Strodl 2024-09-19 200
be777399e9baea Mary Strodl 2024-09-19 201 if (bank_mask) {
be777399e9baea Mary Strodl 2024-09-19 202 ret = gpio_mpsse_get_bank(priv, bank);
be777399e9baea Mary Strodl 2024-09-19 203 if (ret < 0)
be777399e9baea Mary Strodl 2024-09-19 204 return ret;
Needs to mutex_unlock(&priv->io_mutex) before returning.
be777399e9baea Mary Strodl 2024-09-19 205
be777399e9baea Mary Strodl 2024-09-19 206 bitmap_set_value8(bits, ret & bank_mask, i);
be777399e9baea Mary Strodl 2024-09-19 207 }
be777399e9baea Mary Strodl 2024-09-19 208 }
be777399e9baea Mary Strodl 2024-09-19 209 mutex_unlock(&priv->io_mutex);
be777399e9baea Mary Strodl 2024-09-19 210
be777399e9baea Mary Strodl 2024-09-19 @211 return 0;
be777399e9baea Mary Strodl 2024-09-19 212 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki