drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c:573 atmel_hlcdc_plane_update_buffers() error: uninitialized symbol 'sr'.
From: Dan Carpenter
Date: Wed Sep 25 2024 - 06:23:41 EST
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: f8eb5bd9a818cc5f2a1e50b22b0091830b28cc36
commit: d498771b0b830140a70cb8118ee0ee522be94f39 drm: atmel_hlcdc: Add support for XLCDC using IP specific driver ops
config: sparc-randconfig-r071-20240923 (https://download.01.org/0day-ci/archive/20240924/202409240320.MZPgi3Up-lkp@xxxxxxxxx/config)
compiler: sparc64-linux-gcc (GCC) 14.1.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
| Closes: https://lore.kernel.org/r/202409240320.MZPgi3Up-lkp@xxxxxxxxx/
smatch warnings:
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c:573 atmel_hlcdc_plane_update_buffers() error: uninitialized symbol 'sr'.
vim +/sr +573 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
aa71584b323acf Manikandan Muralidharan 2024-04-24 556 static void atmel_hlcdc_plane_update_buffers(struct atmel_hlcdc_plane *plane,
aa71584b323acf Manikandan Muralidharan 2024-04-24 557 struct atmel_hlcdc_plane_state *state)
aa71584b323acf Manikandan Muralidharan 2024-04-24 558 {
aa71584b323acf Manikandan Muralidharan 2024-04-24 559 const struct atmel_hlcdc_layer_desc *desc = plane->layer.desc;
aa71584b323acf Manikandan Muralidharan 2024-04-24 560 struct atmel_hlcdc_dc *dc = plane->base.dev->dev_private;
aa71584b323acf Manikandan Muralidharan 2024-04-24 561 struct drm_framebuffer *fb = state->base.fb;
aa71584b323acf Manikandan Muralidharan 2024-04-24 562 u32 sr;
aa71584b323acf Manikandan Muralidharan 2024-04-24 563 int i;
aa71584b323acf Manikandan Muralidharan 2024-04-24 564
d498771b0b8301 Manikandan Muralidharan 2024-04-24 565 if (!dc->desc->is_xlcdc)
aa71584b323acf Manikandan Muralidharan 2024-04-24 566 sr = atmel_hlcdc_layer_read_reg(&plane->layer, ATMEL_HLCDC_LAYER_CHSR);
Uninitialized on else path.
aa71584b323acf Manikandan Muralidharan 2024-04-24 567
aa71584b323acf Manikandan Muralidharan 2024-04-24 568 for (i = 0; i < state->nplanes; i++) {
aa71584b323acf Manikandan Muralidharan 2024-04-24 569 struct drm_gem_dma_object *gem = drm_fb_dma_get_gem_obj(fb, i);
aa71584b323acf Manikandan Muralidharan 2024-04-24 570
aa71584b323acf Manikandan Muralidharan 2024-04-24 571 state->dscrs[i]->addr = gem->dma_addr + state->offsets[i];
aa71584b323acf Manikandan Muralidharan 2024-04-24 572
aa71584b323acf Manikandan Muralidharan 2024-04-24 @573 dc->desc->ops->lcdc_update_buffers(plane, state, sr, i);
^^
aa71584b323acf Manikandan Muralidharan 2024-04-24 574
9a45d33cdf82f1 Boris Brezillon 2017-02-06 575 if (desc->layout.xstride[i])
9a45d33cdf82f1 Boris Brezillon 2017-02-06 576 atmel_hlcdc_layer_write_cfg(&plane->layer,
9a45d33cdf82f1 Boris Brezillon 2017-02-06 577 desc->layout.xstride[i],
9a45d33cdf82f1 Boris Brezillon 2017-02-06 578 state->xstride[i]);
9a45d33cdf82f1 Boris Brezillon 2017-02-06 579
9a45d33cdf82f1 Boris Brezillon 2017-02-06 580 if (desc->layout.pstride[i])
9a45d33cdf82f1 Boris Brezillon 2017-02-06 581 atmel_hlcdc_layer_write_cfg(&plane->layer,
9a45d33cdf82f1 Boris Brezillon 2017-02-06 582 desc->layout.pstride[i],
2389fc1305fc1e Boris Brezillon 2015-02-05 583 state->pstride[i]);
1a396789f65a22 Boris Brezillon 2015-01-06 584 }
1a396789f65a22 Boris Brezillon 2015-01-06 585 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki