Re: [PATCH] dt-bindings: interconnect: qcom-bwmon: Document QCS8300 bwmon compatibles

[Dmitry Baryshkov]

On Wed, Sep 25, 2024 at 04:40:20PM GMT, Jingyi Wang wrote:
> 
> 
> On 9/25/2024 4:10 PM, Dmitry Baryshkov wrote:
> > On Wed, Sep 25, 2024 at 03:45:06PM GMT, Jingyi Wang wrote:
> >> Document QCS8300 BWMONs, which has two BWMONv4 instances for the CPU->LLCC
> >> path and one BWMONv5 instance for LLCC->DDR path.
> >>
> >> Signed-off-by: Jingyi Wang <quic_jingyw@xxxxxxxxxxx>
> >> ---
> >>  Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml | 2 ++
> >>  1 file changed, 2 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml b/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml
> >> index 189f5900ee50..251410aabf38 100644
> >> --- a/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml
> >> +++ b/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml
> >> @@ -26,6 +26,7 @@ properties:
> >>        - items:
> >>            - enum:
> >>                - qcom,qcm2290-cpu-bwmon
> >> +              - qcom,qcs8300-cpu-bwmon
> > 
> > In most other cases qcs8300 is being declared with the compat fallback
> > to sa8775p compat string. Is there any reason why bwmon is different?
> > 
> All the *cpu-bwmon are fallback to "qcom,sdm845-bwmon", so we add "qcom,qcs8300-cpu-bwmon"
> compatible and fallback to that.

Ack, thanks for the explanation.

> >>                - qcom,sa8775p-cpu-bwmon
> >>                - qcom,sc7180-cpu-bwmon
> >>                - qcom,sc7280-cpu-bwmon
> >> @@ -40,6 +41,7 @@ properties:
> >>            - const: qcom,sdm845-bwmon    # BWMON v4, unified register space
> >>        - items:
> >>            - enum:
> >> +              - qcom,qcs8300-llcc-bwmon
> >>                - qcom,sa8775p-llcc-bwmon
> >>                - qcom,sc7180-llcc-bwmon
> >>                - qcom,sc8280xp-llcc-bwmon
> >>
> >> ---
> >> base-commit: 4d0326b60bb753627437fff0f76bf1525bcda422
> >> change-id: 20240925-qcs8300_bwmon_binding-641d8e4bf376
> >>
> >> Best regards,
> >> -- 
> >> Jingyi Wang <quic_jingyw@xxxxxxxxxxx>
> >>
> > 
> Thanks,
> Jingyi
> 

-- 
With best wishes
Dmitry