Re: [PATCH AUTOSEL 6.11 145/244] ata: pata_serverworks: Do not use the term blacklist

From: Sergei Shtylyov
Date: Wed Sep 25 2024 - 10:41:14 EST


On 9/25/24 14:26, Sasha Levin wrote:

> From: Damien Le Moal <dlemoal@xxxxxxxxxx>
>
> [ Upstream commit 858048568c9e3887d8b19e101ee72f129d65cb15 ]
>
> Let's not use the term blacklist in the function
> serverworks_osb4_filter() documentation comment and rather simply refer
> to what that function looks at: the list of devices with groken UDMA5.
>
> While at it, also constify the values of the csb_bad_ata100 array.
>
> Of note is that all of this should probably be handled using libata
> quirk mechanism but it is unclear if these UDMA5 quirks are specific
> to this controller only.
>
> Signed-off-by: Damien Le Moal <dlemoal@xxxxxxxxxx>
> Reviewed-by: Niklas Cassel <cassel@xxxxxxxxxx>
> Reviewed-by: Igor Pylypiv <ipylypiv@xxxxxxxxxx>
> Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
[...]

Again, what does this fix? :-/

MBR, Sergey