Re: [PATCH] ssb: Call ssb_bus_may_powerdown(bus) only once in ssb_bus_register()

From: Michael Büsch
Date: Wed Sep 25 2024 - 13:10:40 EST


On Tue, 24 Sep 2024 21:33:49 +0200
Markus Elfring <Markus.Elfring@xxxxxx> wrote:

> diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
> index aa6165e3db4a..458858b5472e 100644
> --- a/drivers/ssb/main.c
> +++ b/drivers/ssb/main.c
> @@ -663,11 +663,9 @@ ssb_bus_register(struct ssb_bus *bus,
> ssb_extif_init(&bus->extif);
> ssb_mipscore_init(&bus->mipscore);
> err = ssb_fetch_invariants(bus, get_invariants);
> - if (err) {
> - ssb_bus_may_powerdown(bus);
> - goto err_pcmcia_exit;
> - }
> ssb_bus_may_powerdown(bus);
> + if (err)
> + goto err_pcmcia_exit;
>
> /* Queue it for attach.
> * See the comment at the ssb_is_early_boot definition.


Acked-by: Michael Büsch <m@xxxxxxx>


--
Michael Büsch
https://bues.ch/

Attachment: pgpyYxQz9Ty6i.pgp
Description: OpenPGP digital signature