Re: [PATCH] arm: dts: broadcom: Add missing required fields

[Florian Fainelli]

On 9/25/24 09:39, Stefan Wahren wrote:
> Hi Karan,
>
> Am 25.09.24 um 18:14 schrieb Karan Sanghavi:
> > Added below mentioned required fields
> >    1. interrupt-controller
> >    2. #interrupt-cells
> > in the bcm2711.dtsi file for the
> > interrupt-controller@40000000 block as defined in the
> > bindings/interrupt-controller/brcm,bcm2836-l1-intc.yaml.
> > This issue was noticed while compiling the dtb file
> > for broadcom/bcm2711-rpi-4-b.dts file.
> > After including the above fields in the dtsi file
> > interrupt-conntroller error was resolved.
> looks like you made the same mistake like me [1]. This change breaks
> boot of Raspberry Pi 4 [2].
>
> There are a lot of DT schema warnings to fix, but this doesn't belong to
> the trivial ones.

Including the #interrupt-cells would not have a functional impact 
however, and we ought to be able to do that.

The 'interrupt-controller' property presence means that the controller 
will be picked up by of_irq_init() and that is was causes problems for 
people testing this. Stefan, do you know if the VPU firmware 
removes/inserts that property to tell Linux which interrupt controller 
(bcm2836-l1-intc or ARM GIC) to use or does it make use of the "status" 
property which would be the canonical way about doing that?

Thanks!
--
Florian