Re: [PATCH v2 2/2] drm: fsl-dcu: enable PIXCLK on LS1021A

From: Dmitry Baryshkov
Date: Thu Sep 26 2024 - 02:06:11 EST


On Thu, Sep 26, 2024 at 07:55:51AM GMT, Alexander Stein wrote:
> From: Matthias Schiffer <matthias.schiffer@xxxxxxxxxxxx>
>
> The PIXCLK needs to be enabled in SCFG before accessing certain DCU
> registers, or the access will hang. For simplicity, the PIXCLK is enabled
> unconditionally, resulting in increased power consumption.

By this description it looks like a fix. What is the first broken
commit? It needs to be mentioned in the Fixes: tag. Or is it hat
existing devices have been enabling SCFG in some other way?

>
> Signed-off-by: Matthias Schiffer <matthias.schiffer@xxxxxxxxxxxx>
> Signed-off-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>
> ---
> Changes in v2:
> * Add note about power consumption in commit message
> * Add note about power consumption in comment
> * Fix alignment
>

--
With best wishes
Dmitry