Re: [PATCH] dt-bindings: gpio: ep9301: Add missing "#interrupt-cells" to examples
From: Nikita Shubin
Date: Thu Sep 26 2024 - 02:50:15 EST
Hi Rob!
Thank you!
Reviewed-by: Nikita Shubin <nikita.shubin@xxxxxxxxxxx>
On Wed, 2024-09-25 at 12:35 -0500, Rob Herring (Arm) wrote:
> From: Rob Herring <robh@xxxxxxxxxx>
>
> Enabling dtc interrupt_provider check reveals the examples are
> missing
> the "#interrupt-cells" property as it is a dependency of
> "interrupt-controller".
>
> Some of the indentation is off, so fix that too.
>
> Signed-off-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/gpio/gpio-ep9301.yaml | 9 ++++++--
> -
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-ep9301.yaml
> b/Documentation/devicetree/bindings/gpio/gpio-ep9301.yaml
> index daadfb4926c3..3a1079d6ee20 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-ep9301.yaml
> +++ b/Documentation/devicetree/bindings/gpio/gpio-ep9301.yaml
> @@ -73,9 +73,10 @@ examples:
> reg-names = "data", "dir", "intr";
> gpio-controller;
> #gpio-cells = <2>;
> - interrupt-controller;
> - interrupt-parent = <&vic1>;
> - interrupts = <27>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + interrupt-parent = <&vic1>;
> + interrupts = <27>;
> };
>
> gpio@80840004 {
> @@ -87,6 +88,7 @@ examples:
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> + #interrupt-cells = <2>;
> interrupt-parent = <&vic1>;
> interrupts = <27>;
> };
> @@ -127,6 +129,7 @@ examples:
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> + #interrupt-cells = <2>;
> interrupts-extended = <&vic0 19>, <&vic0 20>,
> <&vic0 21>, <&vic0 22>,
> <&vic1 15>, <&vic1 16>,