Re: [PATCH] dt-bindings: power/supply: qcom,pmi8998-char: Add missing "interrupt-controller" to example

[Krzysztof Kozlowski]

On Wed, Sep 25, 2024 at 12:34:12PM -0500, Rob Herring (Arm) wrote:
> Enabling dtc interrupt_provider check reveals the example is missing
> the "interrupt-controller" property as it is a dependency of
> "#interrupt-cells".
> 
> Signed-off-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
> ---
>  .../devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml   | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml b/Documentation/devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml
> index 277c47e048b6..a1b4926e7190 100644
> --- a/Documentation/devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml
> @@ -61,6 +61,7 @@ examples:
>        #address-cells = <1>;
>        #size-cells = <0>;
>        #interrupt-cells = <4>;
> +      interrupt-controller;

Opposite, the interrupt-cells should be dropped. The parent ("pmic") is
qcom,spmi-pmic.yaml which is not an interrupt controller, according to
the bindings.

Best regards,
Krzysztof