Re: [PATCH] rust: KASAN+RETHUNK requires rustc 1.83.0

[Alice Ryhl]

On Thu, Sep 26, 2024 at 12:34 PM Miguel Ojeda
<miguel.ojeda.sandonis@xxxxxxxxx> wrote:
>
> On Thu, Sep 26, 2024 at 11:39 AM Alice Ryhl <aliceryhl@xxxxxxxxxx> wrote:
> >
> > This is caused by the -Zfunction-return=thunk-extern flag in rustc not
> > properly informing LLVM about the mitigation, which means that the KASAN
>
> "...not informing LLVM about the mitigation at the module level (it
> does so at the function level only currently, which covers most cases,
> but both are required)" or similar?

That phrasing SGTM.

> > This is being fixed for rustc 1.83.0, so update Kconfig to reject this
> > configuration on older compilers.
>
> Yeah, let's go with 1.83.0 as we said -- we can modify it if needed
> later on. I think the PR is fairly straightforward so it should
> probably land in that version unless there is an unknown unknown.
>
> Thanks Alice, looks good to me.
>
> I will take this one soon.

Thanks!

Alice