Re: [PATCH 0/2] usb: typec: ucsi: ccg: Adjustments for common code in two functions
From: Dmitry Baryshkov
Date: Thu Sep 26 2024 - 08:20:43 EST
On Thu, 26 Sept 2024 at 14:12, Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> On Thu, Sep 26, 2024 at 12:26:24AM +0300, Dmitry Baryshkov wrote:
> > On Wed, Sep 25, 2024 at 07:31:04PM GMT, Markus Elfring wrote:
> > > From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> > > Date: Wed, 25 Sep 2024 19:19:01 +0200
> > >
> > > A few update suggestions were taken into account
> > > from static source code analysis.
> > >
> > > Markus Elfring (2):
> > > Use common code in ccg_write()
> > > Use common code in ccg_read()
> > >
> > > drivers/usb/typec/ucsi/ucsi_ccg.c | 15 ++++++++-------
> > > 1 file changed, 8 insertions(+), 7 deletions(-)
> >
> > For the series:
> >
> > Acked-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
>
> I believe there is no-one to take it,
I guessed so.
> but in any case the thing is that kfree()
> probably can be done using __free(). Then PM runtime handled differently.
That's a separate cleanup in my opinion.
--
With best wishes
Dmitry