Re: [PATCH v3] lockdep: add lockdep_cleanup_dead_cpu()
From: Boqun Feng
Date: Thu Sep 26 2024 - 08:35:07 EST
On Thu, Sep 26, 2024 at 01:16:32PM +0100, David Woodhouse wrote:
> On Thu, 2024-09-26 at 05:09 -0700, Boqun Feng wrote:
> >
> >
> > I think this is already fixed by:
> >
> > 9bb69ba4c177 ("ACPI: processor_idle: use raw_safe_halt() in acpi_idle_play_dead()")
> >
> > , no?
>
> That patch fixed the bug.
>
> *This* patch fixes the fact that lockdep didn't *tell* us about the bug.
But I thought along with the above commit, Peter also made it possible
that objtool can detect leaving noinstr section in the offline path? Do
you have a case where you can alter hardirqs_enabled flag in offline
path but don't hit the objtool warning?
Anyway, the commit log needs a rework.
Regards,
Boqun