Re: [PATCH v6 2/3] Documentation: ABI: added filter mode doc in sysfs-bus-iio

[Andy Shevchenko]

On Thu, Sep 26, 2024 at 04:53:56PM +0300, Ramona Alexandra Nechita wrote:
> The filter mode / filter type property is used for ad4130
> and ad7779 drivers, therefore the ABI doc file for ad4130
> was removed, merging both of them in the sysfs-bus-iio.
> Since one of the drivers is available from 6.1, the version
> has been set to 6.1 for these attributes.

...

> +Description:
> +		Reading returns a list with the possible filter modes. Options
> +		for the attribute:
> +			* "sinc3"	- The digital sinc3 filter. Moderate 1st conversion time.
> +		    Good noise performance.
> +			* "sinc4"       - Sinc 4. Excellent noise performance. Long
> +			1st conversion time.
> +			* "sinc5"	- The digital sinc5 filter. Excellent noise performance
> +			* "sinc4+sinc1" - Sinc4 + averaging by 8. Low 1st conversion
> +		    time.
> +			* "sinc3+rej60" - Sinc3 + 60Hz rejection.
> +			* "sinc3+sinc1" - Sinc3 + averaging by 8. Low 1st conversion
> +		    time.
> +			* "sinc3+pf1"   - Sinc3 + device specific Post Filter 1.
> +			* "sinc3+pf2"   - Sinc3 + device specific Post Filter 2.
> +			* "sinc3+pf3"   - Sinc3 + device specific Post Filter 3.
> +			* "sinc3+pf4"   - Sinc3 + device specific Post Filter 4.

I still think that a compromise to leave the existing values as an example in
the existing bindings is a good to have.

But if Jonathan thinks otherwise, I'm not against it.
For the rest
Reviewed-by: Andy Shevchenko <andy@xxxxxxxxxx>

-- 
With Best Regards,
Andy Shevchenko