Re: [syzbot] [v9fs?] WARNING in p9_client_create (2)

[Vlastimil Babka]

On 9/22/24 18:40, asmadeus@xxxxxxxxxxxxx wrote:
> Pedro Falcato wrote on Sun, Sep 22, 2024 at 03:59:17PM +0100:
>> This was one of the issues I actually ran into when using virtme.
>> Fix was submitted here back in August:
>> https://lore.kernel.org/v9fs/20240807094725.2193423-1-pedro.falcato@xxxxxxxxx/
>> 
>> No replies nor was it picked up. Can it go through the slab tree?
> 
> Sorry, we're not getting many patches for 9p so I've been slacking and
> trying to batch a bit for when I can find time to pick them up -- don't
> hesitate to ping again if nobody replied in a week or two.
> 
> In this particular case I remember thinking it was a shame we're
> creating a cache for this when most mounts will be sharing the same
> msize but never found time to actually consider how to share the
> caches... But this isn't anything wrong with the patch itself, sorry for
> the delay.
> (and now I'm thinking about it, I guess the slab code has something to
> regroup identical caches? Just looked and didn't find it but I recall
> something like that...)

Yes it does, and it's active by default (although can be disabled), so you
should be fine without doing the grouping on p9 side.

> Anyway, I've just picked that patch up (don't expect any trouble but
> will be queued to next later today), I'll send it to Linus in a week.

Thanks!

> (I'm also adding the syzbot reported by so this gets closed even if it
> came later)
> 
> Thanks!