Re: [RFC/PATCH bpf-next 0/3] bpf: Add slab iterator and kfunc (v1)

From: Namhyung Kim
Date: Thu Sep 26 2024 - 14:05:01 EST


On Thu, Sep 26, 2024 at 12:16:15AM +0000, Roman Gushchin wrote:
> On Wed, Sep 25, 2024 at 03:30:20PM -0700, Namhyung Kim wrote:
> > Hello,
> >
> > I'm proposing a new iterator and a kfunc for the slab memory allocator
> > to get information of each kmem_cache like in /proc/slabinfo or
> > /sys/kernel/slab.
>
> Hello, Namhyung!

Hello Roman!

>
> I personally like the idea very much. With a growing number of kmem_caches
> /proc/slabinfo getting close to it's limit, so having a more flexible
> interface makes a lot of sense.
>
> > Maybe I need to call it kmem_cache iter but slab
> > was short and easier to call. :)
>
> I'd personally prefer kmem_cache or slab_cache, just in case somebody later
> would propose an iterator over individual slab objects within a kmem_cache.

I think we can add a parameter to limit or extend the functionality
like task iter and cgroup iter. But I'm not sure we need to use a
different name for that. Anyway I'm ok to rename it kmem_cache iter.

>
> Acked-by: Roman Gushchin <roman.gushchin@xxxxxxxxx> (mm/*)

Thanks for your review!
Namhyung