Re: [PATCH v4 3/9] platform/x86: asus-armoury: move existing tunings to asus-armoury module
From: Markus Elfring
Date: Thu Sep 26 2024 - 15:11:40 EST
…
> +++ b/drivers/platform/x86/asus-armoury.h
> @@ -0,0 +1,146 @@
…
> +#ifndef _ASUS_BIOSCFG_H_
> +#define _ASUS_BIOSCFG_H_
…
I suggest to omit leading underscores from such identifiers.
https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier
Regards,
Markus