Re: [PATCH v1 11/11] perf build: Rename PERF_HAVE_DWARF_REGS to PERF_HAVE_LIBDW_REGS
From: Namhyung Kim
Date: Thu Sep 26 2024 - 15:40:15 EST
On Thu, Sep 26, 2024 at 05:47:16AM -0700, Ian Rogers wrote:
> On Wed, Sep 25, 2024 at 8:27 PM Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
> >
> > On Tue, Sep 24, 2024 at 09:04:18AM -0700, Ian Rogers wrote:
> > > The name dwarf can imply libunwind support, whereas
> > > PERF_HAVE_DWARF_REGS is only enabled with libdw support. Rename to
> > > make it clearer there is a libdw connection.
> >
> > While it only covers libdw, I think the idea of this macro is whether
> > the arch has register mappings defined in DWARF standard. So I think
> > it's better to keep the name for this case.
>
> How can the dwarf standard exist for an arch but not define registers?
I meant it's about the arch code in the perf tools to have the mapping,
not the DWARF standard itself.
Thanks,
Namhyung