Re: [PATCH v2 5/8] binder: fix BINDER_WORK_CLEAR_FREEZE_NOTIFICATION debug logs

From: Todd Kjos
Date: Thu Sep 26 2024 - 20:34:30 EST


On Thu, Sep 26, 2024 at 4:36 PM Carlos Llamas <cmllamas@xxxxxxxxxx> wrote:
>
> proc 699
> context binder-test
> thread 699: l 00 need_return 0 tr 0
> ref 25: desc 1 node 20 s 1 w 0 d 00000000c03e09a3
> unknown work: type 11
>
> proc 640
> context binder-test
> thread 640: l 00 need_return 0 tr 0
> ref 8: desc 1 node 3 s 1 w 0 d 000000002bb493e1
> has cleared freeze notification
>
> Fixes: d579b04a52a1 ("binder: frozen notification")
> Cc: stable@xxxxxxxxxxxxxxx
> Suggested-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>
> Signed-off-by: Carlos Llamas <cmllamas@xxxxxxxxxx>

Acked-by: Todd Kjos <tkjos@xxxxxxxxxx>

> ---
> drivers/android/binder.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index 2be9f3559ed7..73dc6cbc1681 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -6411,6 +6411,9 @@ static void print_binder_work_ilocked(struct seq_file *m,
> case BINDER_WORK_FROZEN_BINDER:
> seq_printf(m, "%shas frozen binder\n", prefix);
> break;
> + case BINDER_WORK_CLEAR_FREEZE_NOTIFICATION:
> + seq_printf(m, "%shas cleared freeze notification\n", prefix);
> + break;
> default:
> seq_printf(m, "%sunknown work: type %d\n", prefix, w->type);
> break;
> --
> 2.46.1.824.gd892dcdcdd-goog
>