RE: [PATCH v1] ARM: dts: aspeed: yosemite4: correct the compatible string of adm1272
From: Delphine_CC_Chiu/WYHQ/Wiwynn
Date: Fri Sep 27 2024 - 02:21:41 EST
> -----Original Message-----
> From: Andrew Jeffery <andrew@xxxxxxxxxxxxxxxxxxxx>
> Sent: Friday, September 27, 2024 2:01 PM
> To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@xxxxxxxxxx>;
> patrick@xxxxxxxxx; Rob Herring <robh@xxxxxxxxxx>; Krzysztof Kozlowski
> <krzk+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>; Joel Stanley
> <joel@xxxxxxxxx>
> Cc: Ricky CX Wu <ricky.cx.wu.wiwynn@xxxxxxxxx>;
> devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> linux-aspeed@xxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v1] ARM: dts: aspeed: yosemite4: correct the compatible
> string of adm1272
>
> [External Sender]
>
> [External Sender]
>
> On Thu, 2024-09-26 at 09:34 +0800, Delphine CC Chiu wrote:
> > From: Ricky CX Wu <ricky.cx.wu.wiwynn@xxxxxxxxx>
> >
> > Remove the redundant space in the compatible string of adm1272.
>
> In this case the space is not redundant, it's just incorrect, the compatible string
> doesn't match any specified. Do you mind fixing the wording?
>
Sure, I'll fixing the wording in v2.
> >
> > Signed-off-by: Ricky CX Wu <ricky.cx.wu.wiwynn@xxxxxxxxx>
> > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@xxxxxxxxxx>
>
> Can you please add an appropriate Fixes: tag?
>
> Thanks,
>
> Andrew
>
Would like to ask where should I add the Fixes: tag?
Should I add in the patch title like:
Fixes: ARM: dts: aspeed: yosemite4: correct the compatible string of adm1272
Or should I add in the commit message?