Re: [PATCH v2 1/3] media: ti: cal: Use str_up_down()

From: Andy Shevchenko
Date: Fri Sep 27 2024 - 06:10:51 EST


On Fri, Sep 27, 2024 at 1:02 PM Ricardo Ribalda <ribalda@xxxxxxxxxxxx> wrote:
>
> The str_up_down() helper simplifies the code and fixes the following cocci
> warning:
>
> drivers/media/platform/ti/cal/cal-camerarx.c:194:3-9: opportunity for str_up_down(enable)

...

> if (i == 10)
> phy_err(phy, "Failed to power %s complexio\n",
> - enable ? "up" : "down");
> + str_up_down(enable);

You never tested this, do not bother to send untested material, please!

--
With Best Regards,
Andy Shevchenko