Re: [PATCH v2 0/8] binder: several fixes for frozen notification
From: Alice Ryhl
Date: Fri Sep 27 2024 - 06:21:20 EST
On Fri, Sep 27, 2024 at 1:36 AM Carlos Llamas <cmllamas@xxxxxxxxxx> wrote:
>
> These are all fixes for the frozen notification patch [1], which as of
> today hasn't landed in mainline yet. As such, this patchset is rebased
> on top of the char-misc-next branch.
>
> [1] https://lore.kernel.org/all/20240709070047.4055369-2-yutingtseng@xxxxxxxxxx/
I looked for other inconsistencies between death and freeze
notifications. I found two:
binder_free_proc has this line:
BUG_ON(!list_empty(&proc->delivered_death));
The top comment has this line:
* 3) proc->inner_lock : protects the thread and node lists
* (proc->threads, proc->waiting_threads, proc->nodes)
* and all todo lists associated with the binder_proc
* (proc->todo, thread->todo, proc->delivered_death and
* node->async_todo), as well as thread->transaction_stack
* binder_inner_proc_lock() and binder_inner_proc_unlock()
* are used to acq/rel
Both mention delivered_death but not freeze.
Alice