Re: [PATCH v2 1/3] media: ti: cal: Use str_up_down()

From: Andy Shevchenko
Date: Fri Sep 27 2024 - 06:44:23 EST


On Fri, Sep 27, 2024 at 1:16 PM Ricardo Ribalda <ribalda@xxxxxxxxxxxx> wrote:
> On Fri, 27 Sept 2024 at 12:10, Andy Shevchenko
> <andy.shevchenko@xxxxxxxxx> wrote:
> > On Fri, Sep 27, 2024 at 1:02 PM Ricardo Ribalda <ribalda@xxxxxxxxxxxx> wrote:

...

> > > if (i == 10)
> > > phy_err(phy, "Failed to power %s complexio\n",
> > > - enable ? "up" : "down");
> > > + str_up_down(enable);
> >
> > You never tested this, do not bother to send untested material, please!
>
> Do you mean tested in real hardware or compile test it?

Obviously both as one can't be done without the other.

--
With Best Regards,
Andy Shevchenko