Re: [PATCH] media: i2c: max96717: clean up on error in max96717_subdev_init()
From: Dan Carpenter
Date: Fri Sep 27 2024 - 06:58:00 EST
On Fri, Sep 27, 2024 at 12:47:03PM +0200, Julien Massot wrote:
> Hi,
> On Thu, 2024-09-12 at 11:51 +0300, Dan Carpenter wrote:
> > Call v4l2_ctrl_handler_free() to clean up from
> > v4l2_ctrl_handler_init().
> >
> > Fixes: 50f222455793 ("media: i2c: add MAX96717 driver")
>
> The right commit to fix is:
> Fixes: 19b5e5511ca4f ("media: i2c: max96717: add test pattern ctrl")
>
> Since there was no control to free in the initial driver.
>
> Reviewed-by: Julien Massot <julien.massot@xxxxxxxxxxxxx>
>
Yep. You're right. That makes more sense. I'll resend.
regards,
dan carpenter