Re: [PATCH v2 1/2] dt-bindings: arm: mediatek: Add MT8186 Chinchou/Chinchou360 Chromebooks
From: Krzysztof Kozlowski
Date: Fri Sep 27 2024 - 10:35:12 EST
On 27/09/2024 14:29, Albert Jakieła wrote:
> Add entries for MT8186 based Chinchou/Chinchou360 Chromebooks.
> These two are clamshell or convertible with touchscreen, stylus
> and extra buttons.
>
> Signed-off-by: Albert Jakieła <jakiela@xxxxxxxxxx>
> ---
>
> Changes since v1:
> - PATCH 1/2: Delete sku2147483647
> - Link to v1: https://lore.kernel.org/all/20240925080353.2362879-1-jakiela@xxxxxxxxxx/
>
> ---
> .../devicetree/bindings/arm/mediatek.yaml | 22 +++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> index 1d4bb50fcd8d..47efd96e5659 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> @@ -239,6 +239,28 @@ properties:
> - enum:
> - mediatek,mt8183-pumpkin
> - const: mediatek,mt8183
> + - description: Google Chinchou360 (Asus Chromebook CZ11 Flip CZ1104F)
> + items:
> + - const: google,chinchou-sku16
> + - const: google,chinchou-sku18
> + - const: google,chinchou-sku19
> + - const: google,chinchou-sku21
> + - const: mediatek,mt8186
> + - description: Google Chinchou (Asus Chromebook CZ12 Flip CZ1204C)
> + items:
> + - const: google,chinchou-sku0
> + - const: google,chinchou-sku1
> + - const: google,chinchou-sku2
> + - const: google,chinchou-sku3
> + - const: google,chinchou-sku4
> + - const: google,chinchou-sku5
> + - const: google,chinchou-sku6
> + - const: google,chinchou-sku7
> + - const: google,chinchou-sku17
> + - const: google,chinchou-sku22
> + - const: google,chinchou-sku23
> + - const: google,chinchou
> + - const: mediatek,mt8186
These don't match your DTS. Which also means you did not test your DTS. :(
Best regards,
Krzysztof