Re: [PATCH] sched_ext: Remove redundant p->nr_cpus_allowed checker
From: Tejun Heo
Date: Fri Sep 27 2024 - 16:25:52 EST
On Thu, Sep 26, 2024 at 06:39:49PM +0800, Zhang Qiao wrote:
> select_rq_task() already checked that 'p->nr_cpus_allowed > 1',
> 'p->nr_cpus_allowed == 1' checker in scx_select_cpu_dfl() is redundant.
>
> Signed-off-by: Zhang Qiao <zhangqiao22@xxxxxxxxxx>
Applied to sched_ext/for-6.12-fixes. I think we probably need a flag to tell
the BPF scheduler whether select_cpu has been called or not. Right now, most
schedulers assume that select_cpu() as called before enqueue() on wakeup
path but that's not true for CPU-affine tasks.
Thanks.
--
tejun