Re: [PATCH 04/14] objtool/x86: Add .tail_call_sites

[Josh Poimboeuf]

On Fri, Sep 27, 2024 at 09:49:00PM +0200, Peter Zijlstra wrote:
> @@ -893,7 +893,6 @@ static int create_cfi_sections(struct ob
>  
>  	sec = find_section_by_name(file->elf, ".cfi_sites");
>  	if (sec) {
> -		INIT_LIST_HEAD(&file->call_list);

Hm, why exactly are we re-initing the list head anyway in these
boilerplate create_*_sections() functions?  I'm guessing that backfired
here.  I can't figure out a reason why we'd doing that anyway.

I'm also wondering why we made these boilerplate function names plural
"sections" when they only create a single section :-)

-- 
Josh