Re: [PATCH 6/8] platform/chrome: cros_ec_typec: Displayport support

From: kernel test robot
Date: Sat Sep 28 2024 - 00:28:14 EST


Hi Abhishek,

kernel test robot noticed the following build warnings:

[auto build test WARNING on chrome-platform/for-next]
[also build test WARNING on chrome-platform/for-firmware-next usb/usb-testing usb/usb-next usb/usb-linus linus/master v6.11 next-20240927]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Abhishek-Pandit-Subedi/usb-typec-Add-driver-for-Thunderbolt-3-Alternate-Mode/20240926-002931
base: https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next
patch link: https://lore.kernel.org/r/20240925092505.6.I142fc0c09df58689b98f0cebf1c5e48b9d4fa800%40changeid
patch subject: [PATCH 6/8] platform/chrome: cros_ec_typec: Displayport support
config: i386-randconfig-001-20240928 (https://download.01.org/0day-ci/archive/20240928/202409281250.dtPQ2TrT-lkp@xxxxxxxxx/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240928/202409281250.dtPQ2TrT-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409281250.dtPQ2TrT-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

In file included from drivers/platform/chrome/cros_ec_typec.c:21:
>> drivers/platform/chrome/cros_typec_altmode.h:21:1: warning: no previous prototype for function 'cros_typec_register_displayport' [-Wmissing-prototypes]
21 | cros_typec_register_displayport(struct cros_typec_port *port,
| ^
drivers/platform/chrome/cros_typec_altmode.h:20:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
20 | struct typec_altmode *
| ^
| static
>> drivers/platform/chrome/cros_typec_altmode.h:28:5: warning: no previous prototype for function 'cros_typec_displayport_status_update' [-Wmissing-prototypes]
28 | int cros_typec_displayport_status_update(struct typec_altmode *altmode,
| ^
drivers/platform/chrome/cros_typec_altmode.h:28:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
28 | int cros_typec_displayport_status_update(struct typec_altmode *altmode,
| ^
| static
2 warnings generated.


vim +/cros_typec_register_displayport +21 drivers/platform/chrome/cros_typec_altmode.h

10
11 #if IS_ENABLED(CONFIG_TYPEC_DP_ALTMODE)
12 struct typec_altmode *
13 cros_typec_register_displayport(struct cros_typec_port *port,
14 struct typec_altmode_desc *desc,
15 bool ap_mode_entry);
16
17 int cros_typec_displayport_status_update(struct typec_altmode *altmode,
18 struct typec_displayport_data *data);
19 #else
20 struct typec_altmode *
> 21 cros_typec_register_displayport(struct cros_typec_port *port,
22 struct typec_altmode_desc *desc,
23 bool ap_mode_entry)
24 {
25 return typec_port_register_altmode(port->port, desc);
26 }
27
> 28 int cros_typec_displayport_status_update(struct typec_altmode *altmode,

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki