Re: [PATCH] dt-bindings: usb: add missing compatible arraylist

From: Roger Quadros
Date: Sat Sep 28 2024 - 03:58:34 EST




On 28/09/2024 10:39, Karan Sanghavi wrote:
> On Mon, 23 Sept 2024 at 17:23, Roger Quadros <rogerq@xxxxxxxxxx> wrote:
>>
>> On 22/09/2024 20:00, Karan Sanghavi wrote:
>>> Added the vice versa order for compatible property in the yaml file so
>>> that the dtb can parse for the order mentioned in the dts file
>>> k3-am642-sk.dts for ti,j721e-usb.yaml
>>
>> k3-am642-sk.dts does not introduce any nodes with the said compatibles.
>>
>> "ti,am64-usb" compatible is introduced by k3-am642-main.dtsi.
>> There is only one compatible introduced so there is nothing to do about
>> order here.
>>
>> i.e.
>> usbss0: cdns-usb@f900000 {
>> compatible = "ti,am64-usb";
>> reg = <0x00 0xf900000 0x00 0x100>;
>>
>> What is the functional problem you are facing? Maybe then someone
>> can point you in the right direction.
>>
>
> Sorry for mentioning the wrong file name; yes,
> the problem is in k3-am64-main.dtsi file as mentioned below
>
> usbss0: cdns-usb@f900000 {
> 766 compatible = "ti,am64-usb", "ti,j721e-usb";
> 767 reg = <0x00 0xf900000 0x00 0x100>;
>

Which tree are you looking at?

https://elixir.bootlin.com/linux/v6.11/source/arch/arm64/boot/dts/ti/k3-am64-main.dtsi#L761

usbss0: cdns-usb@f900000 {
compatible = "ti,am64-usb";
reg = <0x00 0xf900000 0x00 0x100>;

> Due to this, it gives an error as in the YAML file the order is in
> reverse order.
> Also, I cloned the repo yesterday and still found the same error in
> the dtsi file.
> So have I done something wrong? as I see I might be out of sync with
> latest changes

You seem to be looking at some old tree. Please refer to latest kernel
tree when submitting changes upstream.

--
cheers,
-roger