Re: [PATCH RFC] PM: sleep: wakeirq: Fix a serious logical error in dev_pm_disarm_wake_irq()

[quic_zijuhu]

On 9/28/2024 6:50 PM, Greg Kroah-Hartman wrote:
> On Sat, Sep 28, 2024 at 02:26:27AM -0700, Zijun Hu wrote:
>> IT is a serious logical error for dev_pm_disarm_wake_irq() not to disable
>> the wake irq enabled by dev_pm_arm_wake_irq(), fixed by simply correcting
>> the wrong if condition.
>>
>> Signed-off-by: Zijun Hu <quic_zijuhu@xxxxxxxxxxx>
> 
> What commit id does this fix?
> 

it is below commit ever mentioned.

tony@xxxxxxxxxxx  2018-02-09
Commit: 69728051f5bf ("PM / wakeirq: Fix unbalanced IRQ enable for wakeirq")

>> ---
>> List relevant commits as following:
>>

there are one more related commit shown below:

qingliang.li@xxxxxxxxxxxx  2024-03-01
Fixes: e7a7681c8596 ("PM: sleep: wakeirq: fix wake irq warning in system
suspend")

>> johan+linaro@xxxxxxxxxx  2023-07-13
>> Commit: 8527beb12087 ("PM: sleep: wakeirq: fix wake irq arming")
>>
>> tony@xxxxxxxxxxx  2018-02-09
>> Commit: 69728051f5bf ("PM / wakeirq: Fix unbalanced IRQ enable for wakeirq")
>>
>> The former commit fixes the later.
> 
> I do not understand this series of commits, what exactly are you trying
> to show here?
>

there are total 3 history commits mentioned, and the 1st fixes the 2nd
which in turn fixes the 3rd, and all these commits involves "unbalanced
wake IRQ enablement"

is the issue "unbalanced wake IRQ enablement" relevant to this weird
logic which looks wrong ?

> confused,
> 
> greg k-h