Re: [PATCH v2 10/10] iio: light: veml6030: add support for veml6035
From: Jonathan Cameron
Date: Sat Sep 28 2024 - 12:25:49 EST
On Mon, 23 Sep 2024 00:17:58 +0200
Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx> wrote:
> The veml6035 is an ALS that shares most of its functionality with the
> veml6030, which allows for some code recycling.
>
> Some chip-specific properties differ and dedicated functions to get and
> set the sensor gain as well as its initialization are required.
>
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx>
Just a trivial formatting follow up comment inline.
Thanks,
Jonathan
> diff --git a/drivers/iio/light/veml6030.c b/drivers/iio/light/veml6030.c
> index 19c69bfad8cb..d5c09c148d22 100644
> --- a/drivers/iio/light/veml6030.c
> +++ b/drivers/iio/light/veml6030.c
> @@ -78,6 +104,15 @@ static const int veml6030_scale_vals[][2] = {
> {2, 0},
> };
>
> +static const int veml6035_scale_vals[][2] = {
> + {0, 125000},
> + {0, 250000},
> + {0, 500000},
> + {1, 0},
> + {2, 0},
> + {4, 0},
Similar to previous comments, add spaces after { and before }
> +};